test_coordinator.py 45 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121
  1. from datetime import date, datetime, time, timedelta
  2. from unittest.mock import AsyncMock, MagicMock, patch
  3. import pytest
  4. from homeassistant.core import HomeAssistant
  5. from homeassistant.exceptions import HomeAssistantError
  6. from pytest_homeassistant_custom_component.common import MockConfigEntry
  7. from custom_components.room_cal_ha.backends import BackendAuthError, BackendConnectError
  8. from custom_components.room_cal_ha.const import (
  9. CONF_API_BASE_URL,
  10. CONF_CALDAV_URL,
  11. CONF_CALENDAR_NAME,
  12. CONF_RESERVATION_DEFAULTS,
  13. CONF_SYNC_MODE,
  14. DOMAIN,
  15. STORE_CURRENT,
  16. STORE_NEXT,
  17. SYNC_MODE_API,
  18. SYNC_MODE_CALDAV,
  19. SYNC_MODE_MANUAL,
  20. )
  21. from custom_components.room_cal_ha.coordinator import RoomCalCoordinator
  22. from custom_components.room_cal_ha.models import OverrideData, ReservationData
  23. SAMPLE = ReservationData(
  24. guest_name="Alice",
  25. check_in_date=date(2026, 7, 1),
  26. check_in_time=time(14, 0),
  27. check_out_date=date(2026, 7, 5),
  28. check_out_time=time(12, 0),
  29. wifi_key="stone-angel-market",
  30. door_code="0472",
  31. )
  32. _BASE_DATA = {
  33. "room_state_name": "Room State",
  34. "current_name": "Current",
  35. "next_name": "Next",
  36. }
  37. def _make_entry(hass, options: dict) -> MockConfigEntry:
  38. entry = MockConfigEntry(domain=DOMAIN, data=_BASE_DATA, options=options)
  39. entry.add_to_hass(hass)
  40. return entry
  41. @pytest.fixture
  42. async def coordinator(hass: HomeAssistant, mock_entry):
  43. mock_entry.add_to_hass(hass)
  44. coord = RoomCalCoordinator(hass, mock_entry)
  45. await coord.async_setup()
  46. return coord
  47. # ---------------------------------------------------------------------------
  48. # Manual mode
  49. # ---------------------------------------------------------------------------
  50. async def test_manual_mode_serves_empty(coordinator: RoomCalCoordinator):
  51. await coordinator.async_refresh()
  52. assert coordinator.data.current == ReservationData()
  53. assert coordinator.data.next == ReservationData()
  54. assert coordinator.data.current_last_refresh is None
  55. assert coordinator.data.next_last_refresh is None
  56. # ---------------------------------------------------------------------------
  57. # CalDAV mode
  58. # ---------------------------------------------------------------------------
  59. async def test_caldav_fetch_writes_store_and_timestamps(hass: HomeAssistant):
  60. entry = _make_entry(hass, {CONF_SYNC_MODE: SYNC_MODE_CALDAV, CONF_CALDAV_URL: "https://cal.example.com", CONF_CALENDAR_NAME: "Room"})
  61. coord = RoomCalCoordinator(hass, entry)
  62. await coord.async_setup()
  63. with patch("custom_components.room_cal_ha.coordinator.CalDavBackend") as MockBackend:
  64. MockBackend.return_value.async_fetch = AsyncMock(return_value=(SAMPLE, None))
  65. await coord.async_refresh()
  66. assert coord.data.current.guest_name == "Alice"
  67. assert coord.data.current.door_code == "0472"
  68. assert coord.data.next == ReservationData()
  69. assert coord.data.current_last_refresh is not None
  70. assert coord.data.next_last_refresh is not None
  71. async def test_caldav_empty_result_clears_store(hass: HomeAssistant):
  72. entry = _make_entry(hass, {CONF_SYNC_MODE: SYNC_MODE_CALDAV, CONF_CALDAV_URL: "https://cal.example.com", CONF_CALENDAR_NAME: "Room"})
  73. coord = RoomCalCoordinator(hass, entry)
  74. await coord.async_setup()
  75. await coord.store.async_set(STORE_CURRENT, SAMPLE)
  76. with patch("custom_components.room_cal_ha.coordinator.CalDavBackend") as MockBackend:
  77. MockBackend.return_value.async_fetch = AsyncMock(return_value=(None, None))
  78. await coord.async_refresh()
  79. assert coord.data.current == ReservationData()
  80. assert coord.store.get(STORE_CURRENT) is None
  81. async def test_caldav_connect_error_preserves_store(hass: HomeAssistant):
  82. entry = _make_entry(hass, {CONF_SYNC_MODE: SYNC_MODE_CALDAV, CONF_CALDAV_URL: "https://cal.example.com", CONF_CALENDAR_NAME: "Room"})
  83. coord = RoomCalCoordinator(hass, entry)
  84. await coord.async_setup()
  85. await coord.store.async_set(STORE_CURRENT, SAMPLE)
  86. with patch("custom_components.room_cal_ha.coordinator.CalDavBackend") as MockBackend:
  87. MockBackend.return_value.async_fetch = AsyncMock(side_effect=BackendConnectError("timeout"))
  88. await coord.async_refresh()
  89. assert coord.data.current.guest_name == "Alice"
  90. assert coord.data.current_last_refresh is None
  91. async def test_caldav_auth_error_triggers_reauth(hass: HomeAssistant):
  92. entry = _make_entry(hass, {CONF_SYNC_MODE: SYNC_MODE_CALDAV, CONF_CALDAV_URL: "https://cal.example.com", CONF_CALENDAR_NAME: "Room"})
  93. coord = RoomCalCoordinator(hass, entry)
  94. await coord.async_setup()
  95. with (
  96. patch("custom_components.room_cal_ha.coordinator.CalDavBackend") as MockBackend,
  97. patch.object(entry, "async_start_reauth") as mock_reauth,
  98. ):
  99. MockBackend.return_value.async_fetch = AsyncMock(side_effect=BackendAuthError)
  100. await coord.async_refresh()
  101. mock_reauth.assert_called_once_with(hass)
  102. # ---------------------------------------------------------------------------
  103. # API mode
  104. # ---------------------------------------------------------------------------
  105. async def test_api_fetch_writes_store(hass: HomeAssistant):
  106. entry = _make_entry(hass, {CONF_SYNC_MODE: SYNC_MODE_API, CONF_API_BASE_URL: "https://api.example.com"})
  107. coord = RoomCalCoordinator(hass, entry)
  108. await coord.async_setup()
  109. with patch("custom_components.room_cal_ha.coordinator.RoomCalApiBackend") as MockBackend:
  110. instance = MockBackend.return_value
  111. instance.async_fetch = AsyncMock(return_value=(SAMPLE, None))
  112. await coord.async_refresh()
  113. assert coord.data.current.guest_name == "Alice"
  114. assert coord.data.current_last_refresh is not None
  115. async def test_api_connect_error_preserves_store(hass: HomeAssistant):
  116. entry = _make_entry(hass, {CONF_SYNC_MODE: SYNC_MODE_API, CONF_API_BASE_URL: "https://api.example.com"})
  117. coord = RoomCalCoordinator(hass, entry)
  118. await coord.async_setup()
  119. await coord.store.async_set(STORE_CURRENT, SAMPLE)
  120. with patch("custom_components.room_cal_ha.coordinator.RoomCalApiBackend") as MockBackend:
  121. instance = MockBackend.return_value
  122. instance.async_fetch = AsyncMock(side_effect=BackendConnectError("timeout"))
  123. await coord.async_refresh()
  124. assert coord.data.current.guest_name == "Alice"
  125. assert coord.data.current_last_refresh is None
  126. async def test_api_auth_error_triggers_reauth(hass: HomeAssistant):
  127. entry = _make_entry(hass, {CONF_SYNC_MODE: SYNC_MODE_API, CONF_API_BASE_URL: "https://api.example.com"})
  128. coord = RoomCalCoordinator(hass, entry)
  129. await coord.async_setup()
  130. with (
  131. patch("custom_components.room_cal_ha.coordinator.RoomCalApiBackend") as MockBackend,
  132. patch.object(entry, "async_start_reauth") as mock_reauth,
  133. ):
  134. instance = MockBackend.return_value
  135. instance.async_fetch = AsyncMock(side_effect=BackendAuthError)
  136. await coord.async_refresh()
  137. mock_reauth.assert_called_once_with(hass)
  138. # ---------------------------------------------------------------------------
  139. # Thin updates
  140. # ---------------------------------------------------------------------------
  141. async def test_thin_update_overlays_fields(coordinator: RoomCalCoordinator):
  142. await coordinator.store.async_set(STORE_CURRENT, SAMPLE)
  143. await coordinator.async_refresh()
  144. await coordinator.async_apply_update(STORE_CURRENT, {"wifi_ssid": "GuestNet", "door_code": "9999"})
  145. assert coordinator.data.current.wifi_ssid == "GuestNet"
  146. assert coordinator.data.current.door_code == "9999"
  147. assert coordinator.data.current.guest_name == "Alice"
  148. assert coordinator.data.current.wifi_key == "stone-angel-market"
  149. async def test_thin_update_updates_last_refresh(coordinator: RoomCalCoordinator):
  150. await coordinator.store.async_set(STORE_CURRENT, SAMPLE)
  151. await coordinator.async_refresh()
  152. assert coordinator.data.current_last_refresh is None
  153. await coordinator.async_apply_update(STORE_CURRENT, {"door_code": "1234"})
  154. assert coordinator.data.current_last_refresh is not None
  155. # ---------------------------------------------------------------------------
  156. # last_updated
  157. # ---------------------------------------------------------------------------
  158. async def test_last_updated_set_when_backend_data_changes(hass: HomeAssistant):
  159. entry = _make_entry(hass, {CONF_SYNC_MODE: SYNC_MODE_CALDAV, CONF_CALDAV_URL: "https://cal.example.com", CONF_CALENDAR_NAME: "Room"})
  160. coord = RoomCalCoordinator(hass, entry)
  161. await coord.async_setup()
  162. next_sample = ReservationData(guest_name="Next")
  163. with patch("custom_components.room_cal_ha.coordinator.CalDavBackend") as MockBackend:
  164. MockBackend.return_value.async_fetch = AsyncMock(return_value=(SAMPLE, next_sample))
  165. await coord.async_refresh()
  166. assert coord.data.current_last_updated is not None
  167. assert coord.data.next_last_updated is not None
  168. async def test_last_updated_not_set_when_backend_data_unchanged(hass: HomeAssistant):
  169. entry = _make_entry(hass, {CONF_SYNC_MODE: SYNC_MODE_CALDAV, CONF_CALDAV_URL: "https://cal.example.com", CONF_CALENDAR_NAME: "Room"})
  170. coord = RoomCalCoordinator(hass, entry)
  171. await coord.async_setup()
  172. await coord.store.async_set(STORE_CURRENT, SAMPLE)
  173. with patch("custom_components.room_cal_ha.coordinator.CalDavBackend") as MockBackend:
  174. MockBackend.return_value.async_fetch = AsyncMock(return_value=(SAMPLE, None))
  175. # First refresh populates self.data
  176. await coord.async_refresh()
  177. ts_after_first = coord.data.current_last_updated
  178. # Second refresh returns same data — last_updated must not change
  179. await coord.async_refresh()
  180. assert coord.data.current_last_updated == ts_after_first
  181. async def test_last_updated_set_on_thin_update_with_change(coordinator: RoomCalCoordinator):
  182. await coordinator.store.async_set(STORE_CURRENT, SAMPLE)
  183. await coordinator.async_refresh()
  184. await coordinator.async_apply_update(STORE_CURRENT, {"door_code": "9999"})
  185. assert coordinator.data.current_last_updated is not None
  186. async def test_last_updated_not_set_on_thin_update_with_same_value(coordinator: RoomCalCoordinator):
  187. await coordinator.store.async_set(STORE_CURRENT, SAMPLE)
  188. await coordinator.async_refresh()
  189. # First update sets last_updated
  190. await coordinator.async_apply_update(STORE_CURRENT, {"door_code": "9999"})
  191. ts = coordinator.data.current_last_updated
  192. # Second update with the same value must not advance last_updated
  193. await coordinator.async_apply_update(STORE_CURRENT, {"door_code": "9999"})
  194. assert coordinator.data.current_last_updated == ts
  195. async def test_last_updated_set_when_override_starts(coordinator: RoomCalCoordinator):
  196. await coordinator.async_refresh()
  197. coordinator._room_state_switch = None
  198. assert coordinator.data.current_last_updated is None
  199. await coordinator.async_start_override(OverrideData(current=ReservationData(guest_name="Override")))
  200. assert coordinator.data.current_last_updated is not None
  201. async def test_last_updated_set_when_override_ends(coordinator: RoomCalCoordinator):
  202. coordinator._room_state_switch = None
  203. await coordinator.async_start_override(OverrideData(current=ReservationData(guest_name="Override")))
  204. ts_start = coordinator.data.current_last_updated
  205. await coordinator.store.async_set(STORE_CURRENT, SAMPLE)
  206. coordinator._override = OverrideData(current=ReservationData(guest_name="Override"))
  207. await coordinator.async_end_override()
  208. assert coordinator.data.current_last_updated != ts_start
  209. async def test_last_updated_persists_across_reload(hass: HomeAssistant, mock_entry):
  210. mock_entry.add_to_hass(hass)
  211. coord = RoomCalCoordinator(hass, mock_entry)
  212. await coord.async_setup()
  213. await coord.store.async_set(STORE_CURRENT, SAMPLE)
  214. await coord.store.async_set_last_updated(STORE_CURRENT, datetime(2026, 1, 1, 12, 0, tzinfo=None))
  215. coord2 = RoomCalCoordinator(hass, mock_entry)
  216. await coord2.async_setup()
  217. loaded = coord2.store.get_last_updated(STORE_CURRENT)
  218. assert loaded is not None
  219. assert loaded.year == 2026
  220. # ---------------------------------------------------------------------------
  221. # Store persistence
  222. # ---------------------------------------------------------------------------
  223. async def test_store_persists_across_reload(hass: HomeAssistant, mock_entry):
  224. mock_entry.add_to_hass(hass)
  225. coord = RoomCalCoordinator(hass, mock_entry)
  226. await coord.async_setup()
  227. await coord.store.async_set(STORE_CURRENT, SAMPLE)
  228. coord2 = RoomCalCoordinator(hass, mock_entry)
  229. await coord2.async_setup()
  230. loaded = coord2.store.get(STORE_CURRENT)
  231. assert loaded is not None
  232. assert loaded.guest_name == "Alice"
  233. assert loaded.door_code == "0472"
  234. # ---------------------------------------------------------------------------
  235. # _reservation_window_state
  236. # ---------------------------------------------------------------------------
  237. DATED = ReservationData(
  238. check_in_date=date(2026, 7, 1),
  239. check_in_time=time(14, 0),
  240. check_out_date=date(2026, 7, 5),
  241. check_out_time=time(12, 0),
  242. )
  243. def _state_at(coordinator, res, dt_str):
  244. """Freeze dt_util.now() to a naive local datetime and call _reservation_window_state."""
  245. frozen = MagicMock()
  246. frozen.replace.return_value = datetime.fromisoformat(dt_str) # naive, no TZ
  247. with patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=frozen):
  248. return coordinator._reservation_window_state(res)
  249. async def test_window_state_active(coordinator):
  250. assert _state_at(coordinator, DATED, "2026-07-03T10:00:00") == "active"
  251. async def test_window_state_pending(coordinator):
  252. assert _state_at(coordinator, DATED, "2026-06-30T10:00:00") == "pending"
  253. async def test_window_state_elapsed(coordinator):
  254. assert _state_at(coordinator, DATED, "2026-07-10T12:00:00") == "elapsed"
  255. async def test_window_state_at_check_in_is_active(coordinator):
  256. assert _state_at(coordinator, DATED, "2026-07-01T14:00:00") == "active"
  257. async def test_window_state_at_check_out_is_elapsed(coordinator):
  258. assert _state_at(coordinator, DATED, "2026-07-05T12:00:00") == "elapsed"
  259. async def test_window_state_no_dates_returns_none(coordinator):
  260. assert coordinator._reservation_window_state(ReservationData()) is None
  261. # ---------------------------------------------------------------------------
  262. # Check-in WiFi key behavior
  263. # ---------------------------------------------------------------------------
  264. _WIFI_NEXT = ReservationData(
  265. guest_name="Bob",
  266. check_in_date=date(2026, 7, 1),
  267. check_in_time=time(14, 0),
  268. check_out_date=date(2026, 7, 5),
  269. check_out_time=time(12, 0),
  270. wifi_ssid="GuestNet",
  271. wifi_key="securepass",
  272. )
  273. # Freeze time at the check-in moment so the window registers as active during check-in tests.
  274. _AT_CHECK_IN = MagicMock()
  275. _AT_CHECK_IN.replace.return_value = datetime(2026, 7, 1, 14, 0, 0)
  276. # Freeze time at (i.e. slightly after) the scheduled check-out moment — this is what
  277. # `dt_util.now()` actually reads when a natural-checkout handler runs in production, and
  278. # is the case that exposed the bug where checkout actions require re-deriving "was old
  279. # active" from wall-clock time (see reservation_diff in models.py).
  280. _AT_CHECK_OUT = MagicMock()
  281. _AT_CHECK_OUT.replace.return_value = datetime(2026, 7, 5, 12, 0, 0)
  282. async def test_check_in_calls_wifi_key(hass: HomeAssistant, coordinator: RoomCalCoordinator):
  283. await coordinator.store.async_set(STORE_NEXT, _WIFI_NEXT)
  284. mock_switch = MagicMock()
  285. mock_switch.async_turn_on = AsyncMock()
  286. coordinator._room_state_switch = mock_switch
  287. with (
  288. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  289. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_IN),
  290. patch("custom_components.room_cal_ha.wifi.async_set_wifi_key", new_callable=AsyncMock) as mock_wifi,
  291. patch("custom_components.room_cal_ha.wifi.async_set_ssid_enabled", new_callable=AsyncMock) as mock_ssid,
  292. ):
  293. await coordinator._async_do_check_in()
  294. coordinator.cancel_mode_sync()
  295. mock_ssid.assert_awaited_once_with(hass, "GuestNet", True)
  296. mock_wifi.assert_awaited_once_with(hass, "GuestNet", "securepass")
  297. mock_switch.async_turn_on.assert_awaited_once()
  298. async def test_check_in_skips_wifi_when_ssid_none(coordinator: RoomCalCoordinator):
  299. await coordinator.store.async_set(STORE_NEXT, ReservationData(wifi_ssid=None, wifi_key="securepass"))
  300. coordinator._room_state_switch = None
  301. with patch("custom_components.room_cal_ha.wifi.async_set_wifi_key", new_callable=AsyncMock) as mock_wifi:
  302. await coordinator._async_do_check_in()
  303. mock_wifi.assert_not_awaited()
  304. async def test_check_in_skips_wifi_when_key_none(coordinator: RoomCalCoordinator):
  305. await coordinator.store.async_set(STORE_NEXT, ReservationData(wifi_ssid="GuestNet", wifi_key=None))
  306. coordinator._room_state_switch = None
  307. with patch("custom_components.room_cal_ha.wifi.async_set_wifi_key", new_callable=AsyncMock) as mock_wifi:
  308. await coordinator._async_do_check_in()
  309. mock_wifi.assert_not_awaited()
  310. async def test_check_in_skips_wifi_when_use_unifi_off(hass: HomeAssistant, coordinator: RoomCalCoordinator):
  311. await coordinator.store.async_set(STORE_NEXT, _WIFI_NEXT)
  312. mock_switch = MagicMock()
  313. mock_switch.async_turn_on = AsyncMock()
  314. coordinator._room_state_switch = mock_switch
  315. with (
  316. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  317. patch.object(coordinator, "_is_use_unifi_on", return_value=False),
  318. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_IN),
  319. patch("custom_components.room_cal_ha.wifi.async_set_ssid_enabled", new_callable=AsyncMock) as mock_ssid,
  320. patch("custom_components.room_cal_ha.wifi.async_set_wifi_key", new_callable=AsyncMock) as mock_wifi,
  321. ):
  322. await coordinator._async_do_check_in()
  323. coordinator.cancel_mode_sync()
  324. mock_ssid.assert_not_awaited()
  325. mock_wifi.assert_not_awaited()
  326. mock_switch.async_turn_on.assert_awaited_once()
  327. async def test_check_in_wifi_error_still_activates_guest_mode(coordinator: RoomCalCoordinator):
  328. await coordinator.store.async_set(STORE_NEXT, _WIFI_NEXT)
  329. mock_switch = MagicMock()
  330. mock_switch.async_turn_on = AsyncMock()
  331. coordinator._room_state_switch = mock_switch
  332. with (
  333. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  334. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_IN),
  335. patch("custom_components.room_cal_ha.wifi.async_set_ssid_enabled", new_callable=AsyncMock),
  336. patch("custom_components.room_cal_ha.wifi.async_set_wifi_key", side_effect=HomeAssistantError("hub down")),
  337. ):
  338. await coordinator._async_do_check_in()
  339. coordinator.cancel_mode_sync()
  340. mock_switch.async_turn_on.assert_awaited_once()
  341. # ---------------------------------------------------------------------------
  342. # Check-out SSID disable behavior
  343. # ---------------------------------------------------------------------------
  344. async def test_check_out_disables_ssid(hass: HomeAssistant, coordinator: RoomCalCoordinator):
  345. await coordinator.store.async_set(STORE_CURRENT, _WIFI_NEXT)
  346. mock_switch = MagicMock()
  347. mock_switch.async_turn_off = AsyncMock()
  348. coordinator._room_state_switch = mock_switch
  349. with (
  350. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  351. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_OUT),
  352. patch("custom_components.room_cal_ha.wifi.async_set_ssid_enabled", new_callable=AsyncMock) as mock_ssid,
  353. ):
  354. await coordinator._async_do_check_out()
  355. mock_ssid.assert_awaited_once_with(hass, "GuestNet", False)
  356. mock_switch.async_turn_off.assert_awaited_once()
  357. async def test_check_out_skips_ssid_when_ssid_none(coordinator: RoomCalCoordinator):
  358. await coordinator.store.async_set(STORE_CURRENT, ReservationData(wifi_ssid=None))
  359. coordinator._room_state_switch = None
  360. with patch("custom_components.room_cal_ha.wifi.async_set_ssid_enabled", new_callable=AsyncMock) as mock_ssid:
  361. await coordinator._async_do_check_out()
  362. mock_ssid.assert_not_awaited()
  363. async def test_check_out_skips_ssid_when_use_unifi_off(coordinator: RoomCalCoordinator):
  364. await coordinator.store.async_set(STORE_CURRENT, _WIFI_NEXT)
  365. coordinator._room_state_switch = None
  366. with (
  367. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  368. patch.object(coordinator, "_is_use_unifi_on", return_value=False),
  369. patch("custom_components.room_cal_ha.wifi.async_set_ssid_enabled", new_callable=AsyncMock) as mock_ssid,
  370. ):
  371. await coordinator._async_do_check_out()
  372. mock_ssid.assert_not_awaited()
  373. async def test_check_out_ssid_error_still_deactivates_guest_mode(coordinator: RoomCalCoordinator):
  374. await coordinator.store.async_set(STORE_CURRENT, _WIFI_NEXT)
  375. mock_switch = MagicMock()
  376. mock_switch.async_turn_off = AsyncMock()
  377. coordinator._room_state_switch = mock_switch
  378. with (
  379. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  380. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_OUT),
  381. patch("custom_components.room_cal_ha.wifi.async_set_ssid_enabled", side_effect=HomeAssistantError("hub down")),
  382. ):
  383. await coordinator._async_do_check_out()
  384. mock_switch.async_turn_off.assert_awaited_once()
  385. # ---------------------------------------------------------------------------
  386. # async_start_override / async_end_override
  387. # ---------------------------------------------------------------------------
  388. _OVERRIDE_RES = ReservationData(guest_name="Override Guest", door_code="1111")
  389. _WIFI_OVERRIDE = ReservationData(guest_name="WiFi Guest", wifi_ssid="GuestNet", wifi_key="secret")
  390. async def test_start_override_sets_current_in_data(coordinator: RoomCalCoordinator):
  391. coordinator._room_state_switch = None
  392. await coordinator.async_start_override(OverrideData(current=_OVERRIDE_RES))
  393. assert coordinator.data.current.guest_name == "Override Guest"
  394. async def test_start_override_sets_override_active_flag(coordinator: RoomCalCoordinator):
  395. coordinator._room_state_switch = None
  396. await coordinator.async_start_override(OverrideData(current=_OVERRIDE_RES))
  397. assert coordinator.data.override_active is True
  398. async def test_start_override_cancels_mode_sync(coordinator: RoomCalCoordinator):
  399. cancel1, cancel2 = MagicMock(), MagicMock()
  400. coordinator._mode_sync_handles = [cancel1, cancel2]
  401. coordinator._room_state_switch = None
  402. await coordinator.async_start_override(OverrideData(current=_OVERRIDE_RES))
  403. cancel1.assert_called_once()
  404. cancel2.assert_called_once()
  405. assert coordinator._mode_sync_handles == []
  406. async def test_start_override_turns_on_guest_mode(coordinator: RoomCalCoordinator):
  407. mock_switch = MagicMock()
  408. mock_switch.async_turn_on = AsyncMock()
  409. coordinator._room_state_switch = mock_switch
  410. active_override = ReservationData(
  411. guest_name=_OVERRIDE_RES.guest_name, door_code=_OVERRIDE_RES.door_code,
  412. check_in_date=date(2026, 7, 1), check_in_time=time(14, 0),
  413. check_out_date=date(2026, 7, 5), check_out_time=time(12, 0),
  414. )
  415. with (
  416. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  417. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_IN),
  418. ):
  419. await coordinator.async_start_override(OverrideData(current=active_override))
  420. coordinator.cancel_mode_sync()
  421. mock_switch.async_turn_on.assert_awaited_once()
  422. async def test_start_override_does_not_turn_on_guest_mode_when_mode_sync_off(coordinator: RoomCalCoordinator):
  423. mock_switch = MagicMock()
  424. mock_switch.async_turn_on = AsyncMock()
  425. coordinator._room_state_switch = mock_switch
  426. with patch.object(coordinator, "_is_mode_sync_on", return_value=False):
  427. await coordinator.async_start_override(OverrideData(current=_OVERRIDE_RES))
  428. mock_switch.async_turn_on.assert_not_awaited()
  429. async def test_start_override_calls_wifi_when_credentials_present(hass: HomeAssistant, coordinator: RoomCalCoordinator):
  430. coordinator._room_state_switch = MagicMock()
  431. coordinator._room_state_switch.async_turn_on = AsyncMock()
  432. active_wifi_override = ReservationData(
  433. guest_name=_WIFI_OVERRIDE.guest_name, wifi_ssid=_WIFI_OVERRIDE.wifi_ssid, wifi_key=_WIFI_OVERRIDE.wifi_key,
  434. check_in_date=date(2026, 7, 1), check_in_time=time(14, 0),
  435. check_out_date=date(2026, 7, 5), check_out_time=time(12, 0),
  436. )
  437. with (
  438. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  439. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_IN),
  440. patch("custom_components.room_cal_ha.wifi.async_set_wifi_key", new_callable=AsyncMock) as mock_wifi,
  441. ):
  442. await coordinator.async_start_override(OverrideData(current=active_wifi_override))
  443. coordinator.cancel_mode_sync()
  444. mock_wifi.assert_awaited_once_with(hass, "GuestNet", "secret")
  445. async def test_start_override_skips_wifi_when_mode_sync_off(coordinator: RoomCalCoordinator):
  446. coordinator._room_state_switch = None
  447. with (
  448. patch.object(coordinator, "_is_mode_sync_on", return_value=False),
  449. patch("custom_components.room_cal_ha.wifi.async_set_wifi_key", new_callable=AsyncMock) as mock_wifi,
  450. ):
  451. await coordinator.async_start_override(OverrideData(current=_WIFI_OVERRIDE))
  452. mock_wifi.assert_not_awaited()
  453. async def test_start_override_skips_wifi_when_ssid_missing(coordinator: RoomCalCoordinator):
  454. coordinator._room_state_switch = None
  455. no_ssid = ReservationData(wifi_ssid=None, wifi_key="secret")
  456. with patch("custom_components.room_cal_ha.wifi.async_set_wifi_key", new_callable=AsyncMock) as mock_wifi:
  457. await coordinator.async_start_override(OverrideData(current=no_ssid))
  458. mock_wifi.assert_not_awaited()
  459. async def test_start_override_uses_store_next_when_override_next_is_none(coordinator: RoomCalCoordinator):
  460. await coordinator.store.async_set(STORE_NEXT, SAMPLE)
  461. coordinator._room_state_switch = None
  462. await coordinator.async_start_override(OverrideData(current=_OVERRIDE_RES))
  463. assert coordinator.data.next.guest_name == "Alice"
  464. async def test_start_override_uses_override_next_when_provided(coordinator: RoomCalCoordinator):
  465. override_next = ReservationData(guest_name="Override Next")
  466. coordinator._room_state_switch = None
  467. await coordinator.async_start_override(OverrideData(current=_OVERRIDE_RES, next=override_next))
  468. assert coordinator.data.next.guest_name == "Override Next"
  469. async def test_start_override_applies_defaults_to_current(hass: HomeAssistant):
  470. entry = MockConfigEntry(
  471. domain=DOMAIN,
  472. data={},
  473. options={
  474. CONF_SYNC_MODE: SYNC_MODE_MANUAL,
  475. CONF_RESERVATION_DEFAULTS: {"wifi_ssid": "DefaultSSID", "check_out_time": "11:00:00"},
  476. },
  477. )
  478. entry.add_to_hass(hass)
  479. coord = RoomCalCoordinator(hass, entry)
  480. await coord.async_setup()
  481. coord._guest_mode_switch = None
  482. partial_override = ReservationData(guest_name="Override Guest")
  483. await coord.async_start_override(OverrideData(current=partial_override))
  484. assert coord.data.current.guest_name == "Override Guest"
  485. assert coord.data.current.wifi_ssid == "DefaultSSID"
  486. assert coord.data.current.check_out_time == time(11, 0)
  487. async def test_start_override_defaults_do_not_overwrite_explicit_fields(hass: HomeAssistant):
  488. entry = MockConfigEntry(
  489. domain=DOMAIN,
  490. data={},
  491. options={
  492. CONF_SYNC_MODE: SYNC_MODE_MANUAL,
  493. CONF_RESERVATION_DEFAULTS: {"wifi_ssid": "DefaultSSID"},
  494. },
  495. )
  496. entry.add_to_hass(hass)
  497. coord = RoomCalCoordinator(hass, entry)
  498. await coord.async_setup()
  499. coord._guest_mode_switch = None
  500. explicit_override = ReservationData(guest_name="Override Guest", wifi_ssid="ExplicitSSID")
  501. await coord.async_start_override(OverrideData(current=explicit_override))
  502. assert coord.data.current.wifi_ssid == "ExplicitSSID"
  503. async def test_refresh_during_override_applies_defaults_to_current(hass: HomeAssistant):
  504. entry = MockConfigEntry(
  505. domain=DOMAIN,
  506. data={},
  507. options={
  508. CONF_SYNC_MODE: SYNC_MODE_MANUAL,
  509. CONF_RESERVATION_DEFAULTS: {"door_code": "9999"},
  510. },
  511. )
  512. entry.add_to_hass(hass)
  513. coord = RoomCalCoordinator(hass, entry)
  514. await coord.async_setup()
  515. coord._guest_mode_switch = None
  516. partial_override = ReservationData(guest_name="Override Guest")
  517. await coord.async_start_override(OverrideData(current=partial_override))
  518. await coord.async_refresh()
  519. assert coord.data.current.guest_name == "Override Guest"
  520. assert coord.data.current.door_code == "9999"
  521. async def test_start_override_applies_defaults_to_store_next(hass: HomeAssistant):
  522. entry = MockConfigEntry(
  523. domain=DOMAIN,
  524. data={},
  525. options={
  526. CONF_SYNC_MODE: SYNC_MODE_MANUAL,
  527. CONF_RESERVATION_DEFAULTS: {"wifi_ssid": "DefaultSSID"},
  528. },
  529. )
  530. entry.add_to_hass(hass)
  531. coord = RoomCalCoordinator(hass, entry)
  532. await coord.async_setup()
  533. coord._guest_mode_switch = None
  534. await coord.store.async_set(STORE_NEXT, ReservationData(guest_name="Next Guest"))
  535. await coord.async_start_override(OverrideData(current=_OVERRIDE_RES))
  536. assert coord.data.next.guest_name == "Next Guest"
  537. assert coord.data.next.wifi_ssid == "DefaultSSID"
  538. async def test_end_override_clears_override_active(coordinator: RoomCalCoordinator):
  539. coordinator._room_state_switch = None
  540. coordinator._override = OverrideData(current=_OVERRIDE_RES)
  541. await coordinator.async_end_override()
  542. assert coordinator.data.override_active is False
  543. async def test_end_override_restores_store_current(coordinator: RoomCalCoordinator):
  544. await coordinator.store.async_set(STORE_CURRENT, SAMPLE)
  545. coordinator._room_state_switch = None
  546. coordinator._override = OverrideData(current=_OVERRIDE_RES)
  547. await coordinator.async_end_override()
  548. assert coordinator.data.current.guest_name == "Alice"
  549. async def test_start_override_with_end_at_schedules_and_ends_override(coordinator: RoomCalCoordinator):
  550. coordinator._room_state_switch = None
  551. override = OverrideData(current=ReservationData(guest_name="Timed Guest"))
  552. with (
  553. patch.object(coordinator, "_is_mode_sync_on", return_value=False),
  554. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_IN),
  555. ):
  556. await coordinator.async_start_override(override, end_at=datetime(2026, 7, 1, 14, 5, 0))
  557. scheduled_handle = coordinator._override_end_handle
  558. assert scheduled_handle is not None
  559. assert coordinator.data.override_active is True
  560. # Simulate the scheduled call_later firing, then cancel the real (never-fired) handle
  561. # so it doesn't leak into the next test.
  562. await coordinator._async_do_override_timeout()
  563. scheduled_handle()
  564. assert coordinator._override_end_handle is None
  565. assert coordinator.data.override_active is False
  566. async def test_stale_override_timeout_does_not_end_a_replacing_override(coordinator: RoomCalCoordinator):
  567. """A timer from an override that was already manually ended/replaced must not end
  568. whatever override is active by the time it fires."""
  569. coordinator._room_state_switch = None
  570. override = OverrideData(current=ReservationData(guest_name="Timed Guest"))
  571. with (
  572. patch.object(coordinator, "_is_mode_sync_on", return_value=False),
  573. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_IN),
  574. ):
  575. await coordinator.async_start_override(override, end_at=datetime(2026, 7, 1, 14, 5, 0))
  576. stale_target = coordinator._override_end_target
  577. await coordinator.async_end_override()
  578. assert coordinator._override is None
  579. new_override = OverrideData(current=ReservationData(guest_name="New Guest"))
  580. with patch.object(coordinator, "_is_mode_sync_on", return_value=False):
  581. await coordinator.async_start_override(new_override) # no end_at — no new timer
  582. # Simulate the original (stale) timer's callback firing late, after the replacement started.
  583. coordinator._override_end_target = stale_target
  584. await coordinator._async_do_override_timeout()
  585. assert coordinator._override is new_override
  586. assert coordinator.data.override_active is True
  587. async def test_start_override_empty_current_triggers_checkout_not_checkin(
  588. hass: HomeAssistant, coordinator: RoomCalCoordinator
  589. ):
  590. """Overriding Current to empty while a real guest is checked in must run checkout
  591. actions (SSID disable, guest-mode off) — not try to check in an empty record."""
  592. checked_in_guest = ReservationData(
  593. guest_name="Real Guest",
  594. check_in_date=date(2026, 7, 1), check_in_time=time(14, 0),
  595. check_out_date=date(2026, 7, 5), check_out_time=time(12, 0),
  596. wifi_ssid="GuestNet", wifi_key="secret",
  597. )
  598. await coordinator.store.async_set(STORE_CURRENT, checked_in_guest)
  599. mock_switch = MagicMock()
  600. mock_switch.async_turn_off = AsyncMock()
  601. mock_switch.async_turn_on = AsyncMock()
  602. coordinator._room_state_switch = mock_switch
  603. with (
  604. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  605. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_IN),
  606. patch("custom_components.room_cal_ha.wifi.async_set_ssid_enabled", new_callable=AsyncMock) as mock_ssid,
  607. ):
  608. await coordinator.async_start_override(OverrideData(current=ReservationData()))
  609. coordinator.cancel_mode_sync()
  610. mock_ssid.assert_awaited_once_with(hass, "GuestNet", False)
  611. mock_switch.async_turn_off.assert_awaited_once()
  612. mock_switch.async_turn_on.assert_not_awaited()
  613. assert coordinator.data.override_active is True
  614. async def test_override_current_checks_out_on_schedule_while_override_stays_active(
  615. hass: HomeAssistant, coordinator: RoomCalCoordinator
  616. ):
  617. """With Mode Sync on, an override's own Current schedules a real check-out handle;
  618. firing it clears the override's Current (not the store's), runs checkout actions,
  619. override_active stays True, and a subsequent Next check-in keeps writing into the
  620. override rather than the store."""
  621. override_guest = ReservationData(
  622. guest_name="Override Guest",
  623. check_in_date=date(2026, 7, 1), check_in_time=time(14, 0),
  624. check_out_date=date(2026, 7, 5), check_out_time=time(12, 0),
  625. )
  626. mock_switch = MagicMock()
  627. mock_switch.async_turn_on = AsyncMock()
  628. mock_switch.async_turn_off = AsyncMock()
  629. coordinator._room_state_switch = mock_switch
  630. with (
  631. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  632. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_IN),
  633. ):
  634. await coordinator.async_start_override(OverrideData(current=override_guest))
  635. assert len(coordinator._mode_sync_handles) >= 1
  636. assert coordinator.data.override_active is True
  637. with (
  638. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  639. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_IN),
  640. ):
  641. await coordinator._async_do_check_out()
  642. coordinator.cancel_mode_sync()
  643. mock_switch.async_turn_off.assert_awaited_once()
  644. assert coordinator.data.override_active is True
  645. assert coordinator.data.current.guest_name is None
  646. assert coordinator.store.get(STORE_CURRENT) is None
  647. await coordinator.store.async_set(STORE_NEXT, ReservationData(guest_name="Next Guest"))
  648. with (
  649. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  650. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_AT_CHECK_IN),
  651. ):
  652. await coordinator._async_do_check_in()
  653. coordinator.cancel_mode_sync()
  654. assert coordinator.data.override_active is True
  655. assert coordinator.data.current.guest_name == "Next Guest"
  656. # The real store's own Current is untouched — the promoted value went into the override.
  657. assert coordinator.store.get(STORE_CURRENT) is None
  658. # ---------------------------------------------------------------------------
  659. # Thin updates during override
  660. # ---------------------------------------------------------------------------
  661. async def test_thin_update_current_during_override_updates_override_not_store(coordinator: RoomCalCoordinator):
  662. await coordinator.store.async_set(STORE_CURRENT, SAMPLE)
  663. await coordinator.async_refresh()
  664. coordinator._override = OverrideData(current=_OVERRIDE_RES)
  665. await coordinator.async_apply_update(STORE_CURRENT, {"door_code": "9999"})
  666. assert coordinator.data.current.door_code == "9999"
  667. # Store is unchanged
  668. assert coordinator.store.get(STORE_CURRENT).door_code == "0472"
  669. async def test_thin_update_current_during_override_data_still_shows_override_active(coordinator: RoomCalCoordinator):
  670. await coordinator.async_refresh()
  671. coordinator._override = OverrideData(current=_OVERRIDE_RES)
  672. await coordinator.async_apply_update(STORE_CURRENT, {"door_code": "9999"})
  673. assert coordinator.data.override_active is True
  674. async def test_thin_update_next_during_override_falls_through_to_store(coordinator: RoomCalCoordinator):
  675. coordinator._override = OverrideData(current=_OVERRIDE_RES) # override.next is None
  676. await coordinator.async_refresh()
  677. await coordinator.async_apply_update(STORE_NEXT, {"guest_name": "Next Guest"})
  678. assert coordinator.store.get(STORE_NEXT).guest_name == "Next Guest"
  679. assert coordinator.data.override_active is True
  680. assert coordinator.data.current.guest_name == "Override Guest"
  681. # ---------------------------------------------------------------------------
  682. # Backend fetch during override preserves override display
  683. # ---------------------------------------------------------------------------
  684. async def test_backend_fetch_during_override_updates_store_but_preserves_override(hass: HomeAssistant):
  685. entry = _make_entry(hass, {CONF_SYNC_MODE: SYNC_MODE_CALDAV, CONF_CALDAV_URL: "https://cal.example.com", CONF_CALENDAR_NAME: "Room"})
  686. coord = RoomCalCoordinator(hass, entry)
  687. await coord.async_setup()
  688. coord._override = OverrideData(current=_OVERRIDE_RES)
  689. backend_data = ReservationData(guest_name="Backend Alice")
  690. with patch("custom_components.room_cal_ha.coordinator.CalDavBackend") as MockBackend:
  691. MockBackend.return_value.async_fetch = AsyncMock(return_value=(backend_data, None))
  692. await coord.async_refresh()
  693. # Store was written by the backend
  694. assert coord.store.get(STORE_CURRENT).guest_name == "Backend Alice"
  695. # But displayed data still shows the override
  696. assert coord.data.current.guest_name == "Override Guest"
  697. assert coord.data.override_active is True
  698. # ---------------------------------------------------------------------------
  699. # async_reconcile_from_store (shared helper)
  700. # ---------------------------------------------------------------------------
  701. _ACTIVE = ReservationData(
  702. guest_name="Active Guest",
  703. check_in_date=date(2026, 6, 20),
  704. check_in_time=time(14, 0),
  705. check_out_date=date(2026, 6, 25),
  706. check_out_time=time(12, 0),
  707. )
  708. _ELAPSED = ReservationData(
  709. guest_name="Past Guest",
  710. check_in_date=date(2026, 6, 1),
  711. check_in_time=time(14, 0),
  712. check_out_date=date(2026, 6, 5),
  713. check_out_time=time(12, 0),
  714. )
  715. _FUTURE = ReservationData(
  716. guest_name="Future Guest",
  717. check_in_date=date(2026, 7, 1),
  718. check_in_time=time(14, 0),
  719. check_out_date=date(2026, 7, 5),
  720. check_out_time=time(12, 0),
  721. )
  722. # Freeze time at 2026-06-22 12:00 local (naive)
  723. _RECONCILE_NOW = MagicMock()
  724. _RECONCILE_NOW.replace.return_value = datetime(2026, 6, 22, 12, 0, 0)
  725. async def test_reconcile_active_current_turns_on_guest_mode(coordinator: RoomCalCoordinator):
  726. await coordinator.store.async_set(STORE_CURRENT, _ACTIVE)
  727. mock_switch = MagicMock()
  728. mock_switch.async_turn_on = AsyncMock()
  729. mock_switch.async_turn_off = AsyncMock()
  730. coordinator._room_state_switch = mock_switch
  731. with (
  732. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  733. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_RECONCILE_NOW),
  734. ):
  735. await coordinator.async_reconcile_from_store()
  736. coordinator.cancel_mode_sync()
  737. mock_switch.async_turn_on.assert_awaited_once()
  738. mock_switch.async_turn_off.assert_not_awaited()
  739. async def test_reconcile_elapsed_current_clears_store_and_turns_off_guest_mode(coordinator: RoomCalCoordinator):
  740. await coordinator.store.async_set(STORE_CURRENT, _ELAPSED)
  741. mock_switch = MagicMock()
  742. mock_switch.async_turn_on = AsyncMock()
  743. mock_switch.async_turn_off = AsyncMock()
  744. coordinator._room_state_switch = mock_switch
  745. with (
  746. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  747. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_RECONCILE_NOW),
  748. ):
  749. await coordinator.async_reconcile_from_store()
  750. assert coordinator.store.get(STORE_CURRENT) is None
  751. mock_switch.async_turn_off.assert_awaited_once()
  752. async def test_reconcile_promotes_next_when_check_in_elapsed(coordinator: RoomCalCoordinator):
  753. await coordinator.store.async_set(STORE_NEXT, _ACTIVE)
  754. with (
  755. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  756. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_RECONCILE_NOW),
  757. ):
  758. await coordinator.async_reconcile_from_store()
  759. coordinator.cancel_mode_sync()
  760. assert coordinator.store.get(STORE_CURRENT).guest_name == "Active Guest"
  761. async def test_reconcile_turns_off_guest_mode_when_store_already_cleared(coordinator: RoomCalCoordinator):
  762. """Store was cleared (e.g. checkout write ran) but guest-mode-off action never ran."""
  763. # No current reservation in store — it was already cleared before HA was disabled.
  764. mock_switch = MagicMock()
  765. mock_switch.async_turn_on = AsyncMock()
  766. mock_switch.async_turn_off = AsyncMock()
  767. coordinator._room_state_switch = mock_switch
  768. with (
  769. patch.object(coordinator, "_is_mode_sync_on", return_value=True),
  770. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_RECONCILE_NOW),
  771. ):
  772. await coordinator.async_reconcile_from_store()
  773. coordinator.cancel_mode_sync()
  774. mock_switch.async_turn_off.assert_awaited_once()
  775. mock_switch.async_turn_on.assert_not_awaited()
  776. async def test_reconcile_does_not_touch_guest_mode_when_mode_sync_off(coordinator: RoomCalCoordinator):
  777. await coordinator.store.async_set(STORE_CURRENT, _ACTIVE)
  778. mock_switch = MagicMock()
  779. mock_switch.async_turn_on = AsyncMock()
  780. mock_switch.async_turn_off = AsyncMock()
  781. coordinator._room_state_switch = mock_switch
  782. with (
  783. patch.object(coordinator, "_is_mode_sync_on", return_value=False),
  784. patch("custom_components.room_cal_ha.coordinator.dt_util.now", return_value=_RECONCILE_NOW),
  785. ):
  786. await coordinator.async_reconcile_from_store()
  787. mock_switch.async_turn_on.assert_not_awaited()
  788. mock_switch.async_turn_off.assert_not_awaited()
  789. # ---------------------------------------------------------------------------
  790. # _diff_with_unifi_check
  791. # ---------------------------------------------------------------------------
  792. _ACTIVE_WIFI_RES = ReservationData(
  793. check_in_date=date(2026, 7, 1),
  794. check_in_time=time(14, 0),
  795. check_out_date=date(2026, 7, 5),
  796. check_out_time=time(12, 0),
  797. wifi_ssid="GuestNet",
  798. wifi_key="correct-key",
  799. )
  800. _DURING_WINDOW = datetime(2026, 7, 3, 12, 0, 0)
  801. def _unifi_diff(coordinator, old, new, now, *, enabled, key):
  802. with (
  803. patch.object(coordinator, "_is_use_unifi_on", return_value=True),
  804. patch("custom_components.room_cal_ha.wifi.get_wlan_state", return_value=(enabled, key)),
  805. ):
  806. return coordinator._diff_with_unifi_check(old, new, now)
  807. async def test_unifi_diff_ssid_disabled_adds_checkin_needed(coordinator):
  808. diff = _unifi_diff(coordinator, None, _ACTIVE_WIFI_RES, _DURING_WINDOW, enabled=False, key="correct-key")
  809. assert diff.checkin_needed
  810. async def test_unifi_diff_key_mismatch_adds_wifi_key_changed(coordinator):
  811. diff = _unifi_diff(coordinator, _ACTIVE_WIFI_RES, _ACTIVE_WIFI_RES, _DURING_WINDOW, enabled=True, key="wrong-key")
  812. assert diff.wifi_key_changed
  813. async def test_unifi_diff_ssid_disabled_and_key_wrong_sets_both(coordinator):
  814. diff = _unifi_diff(coordinator, _ACTIVE_WIFI_RES, _ACTIVE_WIFI_RES, _DURING_WINDOW, enabled=False, key="wrong-key")
  815. assert diff.checkin_needed
  816. assert diff.wifi_key_changed
  817. async def test_unifi_diff_state_matches_no_extra_flags(coordinator):
  818. diff = _unifi_diff(coordinator, _ACTIVE_WIFI_RES, _ACTIVE_WIFI_RES, _DURING_WINDOW, enabled=True, key="correct-key")
  819. assert not diff.has_changes
  820. async def test_unifi_diff_skipped_when_use_unifi_off(coordinator):
  821. with (
  822. patch.object(coordinator, "_is_use_unifi_on", return_value=False),
  823. patch("custom_components.room_cal_ha.wifi.get_wlan_state") as mock_get,
  824. ):
  825. diff = coordinator._diff_with_unifi_check(_ACTIVE_WIFI_RES, _ACTIVE_WIFI_RES, _DURING_WINDOW)
  826. mock_get.assert_not_called()
  827. assert not diff.has_changes # base diff: same record, no changes; unifi check skipped
  828. async def test_unifi_diff_skipped_when_window_not_active(coordinator):
  829. # Unchanged record (no occupancy transition) isolates the UniFi drift-check gate itself:
  830. # even with use_unifi on, no wall-clock-active window means no drift check is made.
  831. before_window = datetime(2026, 6, 30, 12, 0, 0)
  832. with (
  833. patch.object(coordinator, "_is_use_unifi_on", return_value=True),
  834. patch("custom_components.room_cal_ha.wifi.get_wlan_state") as mock_get,
  835. ):
  836. diff = coordinator._diff_with_unifi_check(_ACTIVE_WIFI_RES, _ACTIVE_WIFI_RES, before_window)
  837. mock_get.assert_not_called()
  838. assert not diff.has_changes
  839. async def test_unifi_diff_skipped_when_hub_unavailable(coordinator):
  840. diff = _unifi_diff(coordinator, _ACTIVE_WIFI_RES, _ACTIVE_WIFI_RES, _DURING_WINDOW, enabled=None, key=None)
  841. assert not diff.has_changes
  842. async def test_unifi_diff_key_check_skipped_when_actual_key_none(coordinator):
  843. # Controller doesn't expose passphrase — only enabled state checked.
  844. diff = _unifi_diff(coordinator, _ACTIVE_WIFI_RES, _ACTIVE_WIFI_RES, _DURING_WINDOW, enabled=True, key=None)
  845. assert not diff.has_changes
  846. async def test_unifi_diff_preserves_original_diff_flags(coordinator):
  847. # Even when UniFi state is clean, original checkin_needed from the base diff is kept.
  848. old_inactive = ReservationData(wifi_ssid="GuestNet", wifi_key="correct-key") # no dates → not active
  849. diff = _unifi_diff(coordinator, old_inactive, _ACTIVE_WIFI_RES, _DURING_WINDOW, enabled=True, key="correct-key")
  850. assert diff.checkin_needed # from reservation_diff: old not active, new is active